Skip to content

fix: restore backwards compatibility #1915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 24, 2023
Merged

fix: restore backwards compatibility #1915

merged 2 commits into from
May 24, 2023

Conversation

metacosm
Copy link
Collaborator

  • fix: clean-up unneeded matcher field
  • fix: restore backwards compatibility

metacosm added 2 commits May 24, 2023 22:51
@metacosm
fix: clean-up unneeded matcher field
0c5f1e6
@metacosm
fix: restore backwards compatibility
70195e1 
Note that the current implementation is flawed because custom
ResourceUpdatePreProcessor should be registered to be found when
attempting to use custom matching logic. See also #1914 for more
details.
@metacosm metacosm self-assigned this May 24, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

90.5% 90.5% Coverage
0.0% 0.0% Duplication

@metacosm metacosm merged commit 58b9c04 into main May 24, 2023
@metacosm metacosm deleted the matchers branch May 24, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@metacosm metacosm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@metacosm